Workaround botocore bug in S3 URL Handler backend (Cherry-pick of #19056)
#19110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See boto/botocore#2948 for the upstream bug fix. This only occurs for toekn-based auth, and therefore wasn't caught in tests or in local testing.
kaos
approved these changes
May 23, 2023
huonw
added a commit
that referenced
this pull request
Jun 6, 2023
This adjusts the cherry picking to create the PRs with a milestone attached, so that they're surfaced in the milestone views like https://github.com/pantsbuild/pants/milestone/58, alongside any pending issues and not-yet-cherrypicked PRs. In particular, if a PR is going to be cherry-picked, it'll have the milestone attached and be visible in that view (and any issues it's fixing may also have it tagged)... but once PR merges to `main`, it and any associated issues will be closed. This means they disappear from the milestone view, but there's still work remaining to actually fix them for that milestone: landing the cherry-pick. Pending cherry-pick PRs _can_ be discovered by doing a search like `base:2.17.x` https://github.com/pantsbuild/pants/pulls?q=is%3Apr+is%3Aopen+base%3A2.17.x but it's nice to have only one place to check (the milestone view) rather than needing to remember to also construct that search manually. This is a response to #19110 sitting around for a while and delaying 2.16, due to flaky CI failures: it was hard to notice. See also https://pantsbuild.slack.com/archives/C0D7TNJHL/p1685929902870459 / https://chat.pantsbuild.org/t/12317552/looks-like-https-github-com-pantsbuild-pants-pull-19110-neve#4a387fb1-fc0c-4395-9160-74adf8ab7944 (This will cause some conflicts with #19230, but this PR is a quick win that's easily ported over.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See boto/botocore#2948 for the upstream bug fix.
This only occurs for toekn-based auth, and therefore wasn't caught in tests or in local testing.